Skip to content

feat(India): Bootstrapped GST Setup - #26473

Merged
deepeshgarg007 merged 26 commits into
frappe:developfrom
deepeshgarg007:bootstrapped_gst_setup_develop
Jul 14, 2021
Merged

feat(India): Bootstrapped GST Setup#26473
deepeshgarg007 merged 26 commits into
frappe:developfrom
deepeshgarg007:bootstrapped_gst_setup_develop

Conversation

@deepeshgarg007

@deepeshgarg007 deepeshgarg007 commented Jul 13, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Back Port Of: #25415

no-docs

@deepeshgarg007
feat(India): Separate Input and Output GST tax accounts
2a9726b
@deepeshgarg007
fix: Item Tax templates for GST
de8c6eb
@deepeshgarg007
fix: Add tax categories on company setup
3031535
@deepeshgarg007
fix: Update country-wise-tax JSON and tax setup
e166c26
@deepeshgarg007
fix: Issues on new company setup
a90e5fd
@deepeshgarg007
fix: Ignore validations for Tax Setup
8fd2d8b
@deepeshgarg007
fix: Remove redundant get_doc
8ed1afd
@deepeshgarg007
fix: Gracefully handle duplicate bank account name to make setup faster
1001f29
@deepeshgarg007
fix: Add validation for GST Settings
96300fa
@deepeshgarg007
fix: Add GST accounts to GST Settings
0380cca
@deepeshgarg007
fix: Add accounts and templates for reverse charge
a72589c
@deepeshgarg007
fix: Regional settings setup
269510b
@deepeshgarg007
fix: Check for tax category
ed54e4e
@deepeshgarg007
fix: Move tax categories up in country wise json
87f4df8
@deepeshgarg007
chore: Add comments
b714970
@deepeshgarg007
fix: Tests
22683cf
@deepeshgarg007
fix: Test Cases
0dfea4d
@deepeshgarg007
fix: Revert Changes
2908f2e
@deepeshgarg007
fix: Add validate bank account method back
bb679cc
@deepeshgarg007
fix: Update account heads in GST test cases
779d2af
@deepeshgarg007
fix: Test cases for M-pesa
8f6f86a
@deepeshgarg007
fix: Create mode of payment if doesn't exists
b2af6b4
@deepeshgarg007
fix: Test cases
3ef394c
@deepeshgarg007
fix: Test Cases
2de11fb
@deepeshgarg007 deepeshgarg007 changed the title Bootstrapped gst setup develop feat(India): Bootstrapped GST Setup Jul 13, 2021
@coveralls

coveralls commented Jul 13, 2021 •
edited
Loading

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.0007%) to 42.925% when pulling be773f4 on deepeshgarg007:bootstrapped_gst_setup_develop into c978fdf on frappe:develop.

@deepeshgarg007
deepeshgarg007 merged commit 13fffeb into frappe:develop Jul 14, 2021
@umairsy

umairsy commented Oct 21, 2021 •
edited
Loading

Copy link
Copy Markdown
Member
  • Set default tax rate to zero
  • In Sales Taxes and Charges Master, set rate to zero
  1. The name of Item Tax Template is GST-9%, It should be GST-18%
  2. The chart of account creates tax account heads with a percentage 9 added. It should be 0
  3. The sales tax template and purchase tax template also have a percentage set to 9 or 18 percent. It should be 0.
  4. Further to point 3, the name (description) should also not have 9% in it. This gets printed in Sales Invoice even when the percentage is not 9%
    1. account head where tax percentage should be 0 by default

@deepeshgarg007 can we get these records reviewed and assigned to someone please?

asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@deepeshgarg007
Merge pull request frappe#26473 from deepeshgarg007/bootstrapped_gst_…
4bbd254 
…setup_develop

feat(India): Bootstrapped GST Setup
@deepeshgarg007 deepeshgarg007 mentioned this pull request Jul 18, 2022
Closed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Anurag810 Anurag810 Awaiting requested review from Anurag810
@Mangesh-Khairnar Mangesh-Khairnar Awaiting requested review from Mangesh-Khairnar
@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib
@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@deepeshgarg007 @coveralls @umairsy @nextchamp-saqib